DiamondLightSource / httomo

High-throughput tomography pipeline
https://diamondlightsource.github.io/httomo/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Improve accuracy of 360 stitching memory estimation #363

Open yousefmoazzam opened 3 weeks ago

yousefmoazzam commented 3 weeks ago

Fixes #354

The main changes to the memory estimation are:

Acceptance criteria checklist:

dkazanc commented 2 weeks ago

Thanks, all seem clear me. Pretty memory-hungry one actually.

yousefmoazzam commented 2 weeks ago

One pretty simple way to reduce the amount of memory used is to make the weights array be float32 rather than float64; doing that would halve the amount of memory used by those 4 copies mentioned in the code comments.

I'll make an issue in the httomolibgpu repo so then we can address that at some point :slightly_smiling_face:

dkazanc commented 2 weeks ago

One pretty simple way to reduce the amount of memory used is to make the weights array be float32 rather than float64; doing that would halve the amount of memory used by those 4 copies mentioned in the code comments.

I'll make an issue in the httomolibgpu repo so then we can address that at some point 🙂

Thanks, there is no reason to keep it 64bit.