DiamondLightSource / httomo

High-throughput tomography pipeline
https://diamondlightsource.github.io/httomo/
Other
7 stars 4 forks source link

Remove `--output-folder-path` CLI flag #483

Closed yousefmoazzam closed 1 month ago

yousefmoazzam commented 1 month ago

The motivation behind this flag being added (in #460) was to have the output folder exist when the DLS launcher submitted the SLURM job This was so then the SLURM logfile could be put into the output folder at the time of job submission.

However, after thinking more about it, and looking at what Savu/the Savu launcher did, I don't like this approach and favour the Savu approach (which is to create the dir that the logfile should be put in at job submission time).

This approach makes the --output-folder-path flag unnecessary, so it should be removed.