Closed yousefmoazzam closed 1 month ago
This module contains the old loader (ie, the loader which didn't load individual blocks from the input hdf5/nexus file).
As noted in the standard_tomo() function in this module, it was only kept around due to it being used for the generation of the loader YAML template: https://github.com/DiamondLightSource/httomo/blob/8a55c4dc62aae97d9d7f4d264602a2cfa96cd23e/httomo/data/hdf/loaders.py#L68-L71
standard_tomo()
The YAML template generation script has been moved out of the httomo repo as of #471, and the YAML template for the loader in httomo-backends is (for now) hardcoded/under version control in that repo https://github.com/DiamondLightSource/httomo-backends/blob/1de099b74e534edee6220621417d89464ae3e4c9/httomo_backends/yaml_templates/httomo/httomo.data.hdf.loaders/standard_tomo.yaml.
Therefore, there really seems to be no point in keeping this "skeleton" module around.
This module contains the old loader (ie, the loader which didn't load individual blocks from the input hdf5/nexus file).
As noted in the
standard_tomo()function in this module, it was only kept around due to it being used for the generation of the loader YAML template: https://github.com/DiamondLightSource/httomo/blob/8a55c4dc62aae97d9d7f4d264602a2cfa96cd23e/httomo/data/hdf/loaders.py#L68-L71The YAML template generation script has been moved out of the httomo repo as of #471, and the YAML template for the loader in httomo-backends is (for now) hardcoded/under version control in that repo https://github.com/DiamondLightSource/httomo-backends/blob/1de099b74e534edee6220621417d89464ae3e4c9/httomo_backends/yaml_templates/httomo/httomo.data.hdf.loaders/standard_tomo.yaml.
Therefore, there really seems to be no point in keeping this "skeleton" module around.