Make sure data directory matches GDA format exactly

DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd

BSD 3-Clause "New" or "Revised" License

6 stars 5 forks source link

Make sure data directory matches GDA format exactly #1362

Closed dperl-dls closed 4 months ago

dperl-dls commented 5 months ago

The storage directory is now calculated by hyperion instead of GDA, we need tests to make sure it stays the same to avoid causing issues for users whose scropts might rely on those path patterns.

DominicOram commented 5 months ago

Confirm with Neil if the location of XRC data matters
Find the GDA (and potentially Agamemnon) logic for where data goes
If we can replicate from metadata e.g. visit + sample then do that, otherwise take the path from agamemnon
Write tests that confirm that this is the same for GDA / hyperion

DominicOram commented 5 months ago

Medium

rtuck99 commented 4 months ago

The current behaviour is that the directory is explicitly specified in the storage_directory parameter; this is mapped to the detector_params.directory attribute and we don't currently do any computation on it. It seems to be adequately covered by tests as far as hyperion logic goes, judging by what breaks if you bodge detector_params.directory to return a different value, although I don't think the tests are particularly explicit.

DominicOram commented 4 months ago

I think I agree that this is fine. Thank you