Rotation start omega uses the wrong sign

DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd

BSD 3-Clause "New" or "Revised" License

5 stars 5 forks source link

Rotation start omega uses the wrong sign #1391

Open DominicOram opened 2 months ago

DominicOram commented 2 months ago

When GDA gives a start angle for rotation e.g. 90 deg the rotation actually starts at -90 from GDA's perspective. This is likely because the co-ordinate system in GDA is inverse to that in EPICS e.g. 90 in GDA is -90 in EPICS.

Acceptance Criteria

From GDA's perspective a rotation starting at +90 deg starts at +90 deg

DominicOram commented 1 month ago

Look at fixing this in dodal, if we fix it at this level we will need to account for it in the rotation scan.

DominicOram commented 1 week ago

If the user says start at 90 it should start at 90 in EPICS

dperl-dls commented 4 days ago

~~we should throw this away and fix it properly in epics:~~
- ~~add an alias to allow GDA to keep looking at -omega~~
- ~~use the correct one in Hyperion~~
we should just convert the start position GDA sends to hyperion so that hyperion can always stay in epics coordinates

we think XS