search

DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Tests broken due to https://github.com/DiamondLightSource/dodal/pull/544 #1405

Closed DominicOram closed 1 month ago

DominicOram commented 1 month ago

https://github.com/DiamondLightSource/dodal/pull/544 has broken our tests, we should fix them

DominicOram commented 1 month ago

After fixing for the move of beamline_utils there are additional failures:

FAILED tests/unit_tests/experiment_plans/test_optimise_attenuation_plan.py::test_arm_devices_runs_correct_functions - AssertionError: Expected 'mock' to have been called once. Called 0 times.
FAILED tests/unit_tests/experiment_plans/test_pin_tip_centring.py::test_given_no_tip_found_but_will_be_found_when_get_tip_into_view_then_smargon_moved_positive_and_tip_returned - AssertionError: assert 0 == 0.5
FAILED tests/unit_tests/experiment_plans/test_pin_tip_centring.py::test_given_tip_at_zero_but_will_be_found_when_get_tip_into_view_then_smargon_moved_negative_and_tip_returned - AssertionError: assert 0 == -0.5
FAILED tests/unit_tests/experiment_plans/test_pin_tip_centring.py::test_trigger_and_return_pin_tip_works_for_AD_pin_tip_detection - assert (100, 200) == (200, 100)
FAILED tests/unit_tests/experiment_plans/test_rotation_scan_plan.py::test_rotation_plan_smargon_doesnt_move_xyz_if_not_given_in_params - AssertionError: assert 0.47 == 0