DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

1303 read smargon position in ispyb for rotation scans from hardware not GDA #1411

Closed rtuck99 closed 1 month ago

rtuck99 commented 1 month ago

Fixes #1303

Link to dodal PR (if required): #N/A (remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. the DataCollection Position should now be populated by reading the smargon position instead of GDA
  2. ispyb_extras no longer has the position attribute
  3. Tests pass
olliesilvester commented 1 month ago

Also, we need to remember to do the associated GDA change when merging this

rtuck99 commented 1 month ago

I know this changed happened a while ago, but why is DataCollectionPositionInfo distinct from DataCollectionInfo?

It's a separate sproc that you have to call to do the update, there is a special Position table which is referenced by a foreign-key in DataCollection