search

DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Thaw for a set time straight after robot load #1440

Closed DominicOram closed 4 months ago

DominicOram commented 5 months ago

Fixes #1418

Link to dodal PR (if required): https://github.com/DiamondLightSource/dodal/pull/609

To test:

  1. Confirm that this would kick off the thawer after robot load
DominicOram commented 4 months ago

Looks good, could optionally add a test to check the new abs_set and for the pin_centre_then_xray_centre_params

You're correct, I was being lazy and hoping people wouldn't pick it up, I will do this now

DominicOram commented 4 months ago

Tests are failing due to https://github.com/DiamondLightSource/hyperion/pull/1448

DominicOram commented 4 months ago

Hmm... This is failing because https://github.com/DiamondLightSource/dodal/pull/609#discussion_r1651190757 breaks the assumption that we have here that all Movable things have a name

olliesilvester commented 4 months ago

Hmm... This is failing because DiamondLightSource/dodal#609 (comment) breaks the assumption that we have here that all Movable things have a name

See https://github.com/DiamondLightSource/dodal/pull/609#discussion_r1652376288