search

DiamondLightSource / hyperion

Unattended Data Collection using BlueSky / Ophyd
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

(#1327) ispyb omega_start, axis_start now read from hardware for gridscans #1445

Closed rtuck99 closed 4 months ago

rtuck99 commented 4 months ago

Fixes DiamondLightSource/hyperion#1327 and fixes DiamondLightSource/hyperion#1454

Gridscans should now read populate the omega_start and axis_start values in ispyb by reading the smargon omega directly during grid detection when snapshots are taken. The corresponding changes for rotations will be made in a separate PR ~as this depends on DiamondLightSource/hyperion#1443~ Note that the values will be inverted from previous as they are taken from hardware; this change should be temporary until DiamondLightSource/mx-bluesky#247 is fixed

Link to dodal PR (if required): #N/A (remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. Tests pass
  2. ispyb reports correct omega_start/axis_start/axis_range/axis_end values
DominicOram commented 4 months ago

I think this does fully fix DiamondLightSource/hyperion#1327 so have tagged this as such