search

DiamondLightSource / i22-bluesky

I22 specific bluesky plans and plan stubs
Apache License 2.0
0 stars 0 forks source link

Exclude slow detectors from fast scans #65

Open callumforrester opened 5 months ago

callumforrester commented 5 months ago

From discussion with @coretl we will eventually need multiples of base rates and a system that can determine how fast an individual detector can go based on the desired exposure time. For now we can hard-code the minimum exposure times for each detector and raise an error if the user requests lower. Not doing so causes dropped frames.

stan-dot commented 1 week ago

@callumforrester what is the update on this now? is there somewhere a draft for the algorithm? I can make a PR for error handling, but I guess the minimum exposure times need to be hard-coded into dodal devices. is that right @coretl ?

callumforrester commented 1 week ago

I imagine there are ophyd-async changes needed to support this, but you would have to ask @coretl

stan-dot commented 1 week ago

should this then move into the dodal repo at least? it seems neither soon nor i22 specific

callumforrester commented 1 week ago

I'm not fussed about where this requirement is tracked, but it should be tracked somewhere. If you want to move it please consult with the relevant maintainers.