search

DiamondLightSource / i22-bluesky

I22 specific bluesky plans and plan stubs
Apache License 2.0
0 stars 0 forks source link

add the stop-and make post-stop-frames #76

Closed stan-dot closed 4 months ago

stan-dot commented 4 months ago

Closes #75

this PR adds a piece of logic to ensure the the trigger is detected correctly. the row for 'all the frames after the trigger' must be separate from the row for 'detect the trigger'. While those two were joined, at every repeat the trigger was checked, and that is not what the desired behavior is.

Furthermore we need to check against post_stop_frames > 1 so that we do not pass repeats=0

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.05%. Comparing base (2700dc9) to head (e126f4e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== + Coverage 46.64% 47.05% +0.41% ========================================== Files 11 11 Lines 253 255 +2 ========================================== + Hits 118 120 +2 Misses 135 135 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.