DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

Make a nice way to manage location in `check_files` #161

Open dperl-dls opened 1 month ago

dperl-dls commented 1 month ago
          Could: `check_files` only ever uses `i24` as a location, maybe this because they change the hardcoded location to something else when they do it at the xfel? If that is the case we need a clean way for them to change it rather than have to go through every location? If not the case why pass a location to it at all. Maybe new issue?

_Originally posted by @DominicOram in https://github.com/DiamondLightSource/mx_bluesky/pull/159#discussion_r1719691253_

noemifrisina commented 1 month ago

Once again downloading some information in here.

This ticket might be a part of #90 ... Essentially, yes, we'll need to have a good way of switching locations when they take the code to the xfel, at which point we'll also need to re-instate the xfel specific code. When first going through the code last year, we only left in here what is in use at DLS with the idea of re-adding the xfel bits later on - thus removing all references to the location, which in the original scripts they changed manually in chip_collect - and possibly somewhere in chip_manager.

check_files and write_headers (and I may be forgetting a couple of others so will need to check) are currently not in use - iirc they were part of the full mapping which has been broken for awhile and the beamline scientists would like to reinstate... which is probably why we never got around to removing the location there.