search

DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

Deployment script exits with error if there's any warnings at pytest step #171

Open noemifrisina opened 2 months ago

noemifrisina commented 2 months ago

Running the deployment script currently does not complete but exits with the error:

ERROR:   tests: parallel child exit code 1
  docs: commands succeeded
Traceback (most recent call last):
  File "/scratch/uhz96441/workspaces/mx-bluesky/./deploy/deploy_mxbluesky.py", line 169, in <module>
    run_process_and_print_output("./dls_dev_setup.sh")
  File "/scratch/uhz96441/workspaces/mx-bluesky/./deploy/deploy_mxbluesky.py", line 124, in run_process_and_print_output
    raise CalledProcessError(p.returncode, p.args)
subprocess.CalledProcessError: Command './dls_dev_setup.sh' returned non-zero exit status 1.

This happens because of this , which is good to have but causes the deployment script to exit before completing. As this is after the virtual environment is installed, only minor tasks are left over, such as creating the softlinks. While we can take care of this at a later time, we should have a deployment script that goes through all the steps if the virtual environment is installed.

Steps To Reproduce

Steps to reproduce the behavior:

  1. From your local environment run the deployment script with --dev-path

Acceptance Criteria

noemifrisina commented 2 months ago

Underlining issue causing this is this DeprecationWarning:

ERROR tests/test_example.py - DeprecationWarning: The 'wheel' package is no longer the canonical location of the 'bdist_wheel' command, and will be removed in a future release. Please update to setuptools v70.1 or later which contains an integrated version of this command.
DominicOram commented 2 months ago

The depreciation warning is happening because https://github.com/epics-base/setuptools_dso is getting bdist_wheel from wheel. As of wheel version 0.44.0 and this lives in setuptools v70.1 this is inside setuptools itself.

DominicOram commented 2 months ago

See https://github.com/epics-base/setuptools_dso/issues/36

dperl-dls commented 2 months ago

fixing the deprecation is good, but do we want this to always stop deployment? we could run the deployment tests with filterwarnings turned off