DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

Put waiting logic on device side #381

Open DominicOram opened 1 year ago

DominicOram commented 1 year ago

https://github.com/DiamondLightSource/python-artemis/issues/248 added some logic for waiting to check that our scan was valid. However, we shouldn't be doing this polling waiting in the plan, instead we should refactor the device so that we can use bps.wait in the plan. We have copied all over the code now, and they should all be updated to a nicer pattern:

Note

DominicOram commented 1 year ago

Same is true for wait_for_det_to_finish_moving

DominicOram commented 1 year ago

Arm/Disarm done in https://github.com/DiamondLightSource/python-artemis/issues/749