DominicOram
commented
1 year ago We also do some additional aggregation that would be helpful to PVs (see https://github.com/DiamondLightSource/python-artemis/blob/64839c263f10b8dee7e3395dcb58b1a74f739ff0/src/artemis/devices/eiger_odin.py#L50):
- Check if any filewriters have timed out frames
- Check if any filewriters have dropped frames
- Aggregate the error state of all the writers
- Check all initialised
- Clear errors on all
If all the above could be moved to the IOC it would mean we no longer have to keep track of individual writers at all. Happy to discuss though
Currently we know we're finished when the meta writer and all file writers are finished. It would be a bit cleaner if odin had a top level PV that we could check for all writers to have been finished that would do this aggregation for us. FYI @GDYendell