search

DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

beam centre/resolution display is wrong in ispyb #404

Open dperl-dls opened 2 years ago

dperl-dls commented 2 years ago

Not sure if this is an artemis issue or an ispyb issue but the error is only there for images from grid scans, images from normal data collection are not affected.

Screenshot from 2022-10-07 11-01-00 Screenshot from 2022-10-07 11-01-41

Centre of the image used for calculating resolution displayed in synchweb is off (see screenshots).

Not off by the same amount as DiamondLightSource/hyperion#253, it's diagonally towards the upper left instead of only in x.

DominicOram commented 2 years ago

Is this the same issue as https://github.com/DiamondLightSource/python-artemis/issues/113?

dperl-dls commented 2 years ago

no, this issue concerns the beam centre in the diffraction image, DiamondLightSource/hyperion#113 is about the x/y/z position in the grid scan

dperl-dls commented 2 years ago

to clarify, the "beam centre" is also where the "resolution" on mouseover in the display of the image (not in the side panel) should go to infinity.

I guess to resolve whether this is our problem or synchweb's we just check a few images and make sure the beam centre is correct in them. in some recent grid scans the problem is still there in roi mode images. it's not there in full size images.