DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines

https://diamondlightsource.github.io/mx-bluesky/

Apache License 2.0

0 stars 2 forks source link

Document how to run in a dev container #407

Open DominicOram opened 1 year ago

DominicOram commented 1 year ago

The dev script currently fails in REHL 8 as pipenv is not on the path. We should probably move to using devcontainers for development anyway.

Acceptance Criteria

There is a devcontainer json file in the repo (see https://github.com/DiamondLightSource/python-artemis/tree/artemis_dev_container)
pre-commit hooks are installed by default with the devcontainer
It is documented how to use this and run the unit tests

dperl-dls commented 1 year ago

So here it's running in a devcontainer, pre-commit hooks work, tests work, etc., but it is not in a virtualenv. If this is what we want then I will go ahead and document it.