DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

Remove `from_json` #457

Open DominicOram opened 2 months ago

DominicOram commented 2 months ago

Now that we're using pydantic 2 and not dynamically changing the extra fields at runtime (https://github.com/DiamondLightSource/mx-bluesky/pull/456) we should not need to have our custom from_json method and just be able to use model_validate_json. However, when I tried to do this I found a number of validation errors in the tests.

Acceptance Criteria