XRC not opening shutter on first or second grid scan

[olliesilvester]

With Hyperion running on mx-bluesky v1.1.0, XRC grid scans didn't open the fast shutter. see https://ispyb.diamond.ac.uk/dc/visit/cm37235-4/dcg/13008691. This was caused by the changes done with the ZebraShutter and auto/manual mode

Acceptance Criteria

• Fix bug and add tests
• Create a diagram which explains how the Zebra + shutter should be configured

[olliesilvester]

Error here occured at 09:38 on 2/10/24. And again at 09:41

• [Wed Oct 2 09:37:56 2024]gda2@i03-control.diamond.ac.uk BL03I-EA-SHTR-01:CTRL1.VAL Manual -> Auto
• Scan starts running at 09:38:20 (Seen via archived BL03I-EA-SHTR-01:CTRL1)
• The PV associated with Zebra TTLIN4 changes at the same time as the grid scan
• [Wed Oct 2 09:38:37 2024]gda2@i03-control.diamond.ac.uk BL03I-EA-SHTR-01:CTRL1.VAL Auto -> Manual
• Shutter doesnt open at all during scan (seen via archived BL03I-EA-SHTR-01:STA). The and gate also doesn't send a signal. BL03I-EA-ZEBRA-01:AND2_OUT stays at 0.

This suggests that either the AND2 gate isn't correctly configured to use TTL4 as inputs, or that TTL4 isn't being sent at the right time. Former is more likely

[olliesilvester]

OK, I think this is the problem:

• The two inputs of the AND2 gate (which controls the fast shutter) are normally set to 30 (PC_GATE)
• The two PV's are BL03I-EA-ZEBRA-01:AND2_INP1 and BL03I-EA-ZEBRA-01:AND2_INP2
• After https://github.com/DiamondLightSource/mx-bluesky/pull/446/files, we set BL03I-EA-ZEBRA-01:AND2_INP1 to TTLIN4 (which is the trigger sent from the motion controller), but we don't set BL03I-EA-ZEBRA-01:AND2_INP2.
• This explains why rotations still worked - since INP2 is always set to PC_GATE, so only changing INP1 was enough

Fixed by making sure that the AND2 gate on the zebra has both its inputs configured. The first input should ALWAYS be on if shutter is set to auto. For grid scans, the second input should be set to TTLIN4 (which is the physical signal sent by the motion controller during FGS motion script) For rotations, the second input should be set to PC_GATE (position compare)

[olliesilvester]

Hotfixed on i03's latest hyperion