Multipin testing 08/10

[DominicOram]

Issues found:

• Number of frames per trigger needs to be the number per each rotation rather than full collection
• GDA needed to pass in GPU and multipin things to GUP
• Plan needed to be a MsgGenerator and be imported in src/mx_bluesky/hyperion/experiment_plans/__init__.py
• Needed to correct the starting VDS in the Multi, did this by calling multi_rotation = MultiRotationScan.model_validate(multi_rotation)
• Processing of early collections looks to fail, we think due to us triggering zocalo whilst still collecting data
• We're not respecting the transmission that GDA is giving us - we think this is because the parameter validation in LoadCentreCollect is creating a very complex object:

  {
  "select_centres": {
  "name": "top_n_by_max_count",
  "n": 3
  },
  "sample_id": 5995228,
  "sample_puck": 1,
  "sample_pin": 4,
  "visit": "cm37235-4",
  "zocalo_environment": "artemis",
  "beamline": "BL03I",
  "det_dist_to_beam_converter_path": "/dls_sw/i03/software/daq_configuration/lookup/DetDistToBeamXYConverter.txt",
  "insertion_prefix": "SR03I",
  "detector_distance_mm": 250.91171812606459,
  "features": {
  "use_panda_for_gridscan": false,
  "use_gpu_for_gridscan": true,
  "set_stub_offsets": false
  },
  "parameter_model_version": "5.0.0",
  "robot_load_then_centre": {
  "oav_centring_file": "/dls_sw/i03/software/daq_configuration/json/OAVCentring_hyperion.json",
  "omega_start_deg": 0.0,
  "phi_start_deg": null,
  "chi_start_deg": 0.0,
  "kappa_start_deg": null,
  "sample_id": 5995228,
  "sample_puck": 1,
  "sample_pin": 4,
  "visit": "cm37235-4",
  "zocalo_environment": "artemis",
  "beamline": "BL03I",
  "det_dist_to_beam_converter_path": "/dls_sw/i03/software/daq_configuration/lookup/DetDistToBeamXYConverter.txt",
  "insertion_prefix": "SR03I",
  "detector_distance_mm": 250.91171812606459,
  "demand_energy_ev": 12699.999999450105,
  "snapshot_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1/snapshots",
  "snapshot_omegas_deg": null,
  "features": {
    "use_panda_for_gridscan": false,
    "use_gpu_for_gridscan": true,
    "set_stub_offsets": false
  },
  "parameter_model_version": "5.0.0",
  "file_name": "protk_1",
  "exposure_time_s": 0.004,
  "comment": "",
  "trigger_mode": 2,
  "run_number": null,
  "selected_aperture": "SMALL_APERTURE",
  "transmission_frac": 1.0,
  "ispyb_experiment_type": "Mesh3D",
  "storage_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1",
  "grid_width_um": 2200.0,
  "use_roi_mode": true,
  "panda_runup_distance_mm": 0.17,
  "use_panda": false,
  "use_gpu": false,
  "use_cpu_and_gpu_zocalo": true,
  "thawing_time": 20.0,
  "multi_rotation_scan": {
    "storage_directory": "/dls/i03/data/2024/cm37235-4/TestProteinaseK/protk_1",
    "exposure_time_s": 0.004,
    "rotation_increment_deg": 0.1,
    "file_name": "protk_1",
    "snapshot_omegas_deg": [
      0,
      90,
      180,
      270
    ],
    "rotation_scans": [
      {
        "rotation_axis": "omega",
        "ispyb_experiment_type": "SAD",
        "omega_start_deg": 0.0,
        "chi_start_deg": 0.0,
        "rotation_direction": "Negative",
        "transmission_frac": 0.03000228852033615,
        "scan_width_deg": 90.0
      }
    ],
    "comment": "Hyperion Rotation Scan - ",
    "demand_energy_ev": 12699.999999450105
  },
  "select_centres": {
    "n": 3,
    "name": "top_n_by_max_count"
  },
  "robot_load_then_centre": {
    "storage_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1",
    "grid_width_um": 2200,
    "exposure_time_s": 0.004,
    "use_cpu_and_gpu_zocalo": true,
    "file_name": "protk_1",
    "omega_start_deg": 0,
    "tip_offset_um": 900,
    "use_roi_mode": true,
    "chi_start_deg": 0.0,
    "use_panda": false,
    "demand_energy_ev": 12699.999999450105,
    "transmission_frac": 1.0
  },
  "tip_offset_um": 900
  },
  "multi_rotation_scan": {
  "sample_id": 5995228,
  "sample_puck": 1,
  "sample_pin": 4,
  "visit": "cm37235-4",
  "zocalo_environment": "artemis",
  "beamline": "BL03I",
  "det_dist_to_beam_converter_path": "/dls_sw/i03/software/daq_configuration/lookup/DetDistToBeamXYConverter.txt",
  "insertion_prefix": "SR03I",
  "detector_distance_mm": 250.91171812606459,
  "demand_energy_ev": 12699.999999450105,
  "snapshot_directory": "/dls/i03/data/2024/cm37235-4/TestProteinaseK/protk_1/snapshots",
  "snapshot_omegas_deg": [
    0.0,
    90.0,
    180.0,
    270.0
  ],
  "features": {
    "use_panda_for_gridscan": false,
    "use_gpu_for_gridscan": true,
    "set_stub_offsets": false
  },
  "parameter_model_version": "5.0.0",
  "file_name": "protk_1",
  "exposure_time_s": 0.004,
  "comment": "Hyperion Rotation Scan - ",
  "trigger_mode": 2,
  "run_number": null,
  "selected_aperture": null,
  "transmission_frac": 0.1,
  "ispyb_experiment_type": "SAD",
  "storage_directory": "/dls/i03/data/2024/cm37235-4/TestProteinaseK/protk_1",
  "shutter_opening_time_s": 0.06,
  "rotation_increment_deg": 0.1,
  "rotation_scans": [
    {
      "x_start_um": null,
      "y_start_um": null,
      "z_start_um": null,
      "omega_start_deg": 0.0,
      "phi_start_deg": null,
      "chi_start_deg": 0.0,
      "kappa_start_deg": null,
      "rotation_axis": "omega",
      "scan_width_deg": 90.0,
      "rotation_direction": "Negative",
      "nexus_vds_start_img": 0
    }
  ],
  "multi_rotation_scan": {
    "storage_directory": "/dls/i03/data/2024/cm37235-4/TestProteinaseK/protk_1",
    "exposure_time_s": 0.004,
    "rotation_increment_deg": 0.1,
    "file_name": "protk_1",
    "snapshot_omegas_deg": [
      0,
      90,
      180,
      270
    ],
    "rotation_scans": [
      {
        "rotation_axis": "omega",
        "ispyb_experiment_type": "SAD",
        "omega_start_deg": 0.0,
        "chi_start_deg": 0.0,
        "rotation_direction": "Negative",
        "transmission_frac": 0.03000228852033615,
        "scan_width_deg": 90.0
      }
    ],
    "comment": "Hyperion Rotation Scan - ",
    "demand_energy_ev": 12699.999999450105
  },
  "select_centres": {
    "n": 3,
    "name": "top_n_by_max_count"
  },
  "robot_load_then_centre": {
    "oav_centring_file": "/dls_sw/i03/software/daq_configuration/json/OAVCentring_hyperion.json",
    "omega_start_deg": 0.0,
    "phi_start_deg": null,
    "chi_start_deg": 0.0,
    "kappa_start_deg": null,
    "sample_id": 5995228,
    "sample_puck": 1,
    "sample_pin": 4,
    "visit": "cm37235-4",
    "zocalo_environment": "artemis",
    "beamline": "BL03I",
    "det_dist_to_beam_converter_path": "/dls_sw/i03/software/daq_configuration/lookup/DetDistToBeamXYConverter.txt",
    "insertion_prefix": "SR03I",
    "detector_distance_mm": 250.91171812606459,
    "demand_energy_ev": 12699.999999450105,
    "snapshot_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1/snapshots",
    "snapshot_omegas_deg": null,
    "features": {
      "use_panda_for_gridscan": false,
      "use_gpu_for_gridscan": true,
      "set_stub_offsets": false
    },
    "parameter_model_version": "5.0.0",
    "file_name": "protk_1",
    "exposure_time_s": 0.004,
    "comment": "",
    "trigger_mode": 2,
    "run_number": null,
    "selected_aperture": "SMALL_APERTURE",
    "transmission_frac": 1.0,
    "ispyb_experiment_type": "Mesh3D",
    "storage_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1",
    "grid_width_um": 2200.0,
    "use_roi_mode": true,
    "panda_runup_distance_mm": 0.17,
    "use_panda": false,
    "use_gpu": false,
    "use_cpu_and_gpu_zocalo": true,
    "thawing_time": 20.0,
    "multi_rotation_scan": {
      "storage_directory": "/dls/i03/data/2024/cm37235-4/TestProteinaseK/protk_1",
      "exposure_time_s": 0.004,
      "rotation_increment_deg": 0.1,
      "file_name": "protk_1",
      "snapshot_omegas_deg": [
        0,
        90,
        180,
        270
      ],
      "rotation_scans": [
        {
          "rotation_axis": "omega",
          "ispyb_experiment_type": "SAD",
          "omega_start_deg": 0.0,
          "chi_start_deg": 0.0,
          "rotation_direction": "Negative",
          "transmission_frac": 0.03000228852033615,
          "scan_width_deg": 90.0
        }
      ],
      "comment": "Hyperion Rotation Scan - ",
      "demand_energy_ev": 12699.999999450105
    },
    "select_centres": {
      "n": 3,
      "name": "top_n_by_max_count"
    },
    "robot_load_then_centre": {
      "storage_directory": "/dls/i03/data/2024/cm37235-4/xraycentring/TestProteinaseK/protk_1",
      "grid_width_um": 2200,
      "exposure_time_s": 0.004,
      "use_cpu_and_gpu_zocalo": true,
      "file_name": "protk_1",
      "omega_start_deg": 0,
      "tip_offset_um": 900,
      "use_roi_mode": true,
      "chi_start_deg": 0.0,
      "use_panda": false,
      "demand_energy_ev": 12699.999999450105,
      "transmission_frac": 1.0
    },
    "tip_offset_um": 900
  }
  }

But generally got good data at https://ispyb.diamond.ac.uk/dc/visit/cm37235-4/dcg/13116181

[rtuck99]

Also robot_load_then_centre followed by rotation_scan gridscans worked successfully but rotations didn't appear to find anything, see e.g. https://ispyb.diamond.ac.uk/dc/visit/cm37235-4/id/15512407

[rtuck99]

Also aperture is not set correctly for multipin - see #561