search

DiamondLightSource / mx-bluesky

Bluesky plans, plan stubs, and utilities for MX beamlines
https://diamondlightsource.github.io/mx-bluesky/
Apache License 2.0
0 stars 2 forks source link

Remove `from_json` in parameter model #628

Closed DominicOram closed 1 week ago

DominicOram commented 2 weeks ago

Fixes #457

Contains changes from https://github.com/DiamondLightSource/mx-bluesky/pull/629, make sure that is merged first

To Test:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.64%. Comparing base (fe31796) to head (c3462dc). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #628 +/- ## ======================================= Coverage 82.64% 82.64% ======================================= Files 98 98 Lines 6551 6551 ======================================= Hits 5414 5414 Misses 1137 1137 ``` | [Components](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/628/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | Coverage Δ | | |---|---|---| | [i24 SSX](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/628/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `64.10% <ø> (ø)` | | | [hyperion](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/628/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `96.79% <100.00%> (+<0.01%)` | :arrow_up: | | [other](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/628/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `94.97% <100.00%> (-0.06%)` | :arrow_down: |