search

DiamondLightSource / mx_bluesky

Holds Bluesky code used in MX but outside the Hyperion project
Apache License 2.0
0 stars 1 forks source link

Beamline test fixes #76

Closed noemifrisina closed 5 months ago

noemifrisina commented 5 months ago

Fixes from testing on beamline Dec23/Jan24

Takes care of some of the issues listed in #75

codecov[bot] commented 5 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6098ef6) 48.98% compared to head (c32b0ab) 49.15%.

:exclamation: Current head c32b0ab differs from pull request most recent head 85670c7. Consider uploading reports for the commit 85670c7 to get more accurate results

Files Patch % Lines
...esky/I24/serial/fixed_target/i24ssx_moveonclick.py 35.00% 13 Missing :warning:
...4/serial/fixed_target/i24ssx_Chip_Collect_py3v1.py 75.00% 1 Missing :warning:
...4/serial/fixed_target/i24ssx_Chip_Manager_py3v1.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== + Coverage 48.98% 49.15% +0.16% ========================================== Files 22 22 Lines 3352 3361 +9 ========================================== + Hits 1642 1652 +10 + Misses 1710 1709 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

noemifrisina commented 5 months ago

Code changes now tested on the beamline