Open DominicOram opened 1 year ago
First part of the work done in #110 and Artemis#599. Scans are calculated and passed directly from artemis. End and increment positions are now optional, but for the moment the start position is not. Merging #110 to get this first change working. There's still some work to be done on creating omega if not passed (and some tests to be added) but that will go in another PR.
As a user of nexgen I would like to provide the scan details myself rather than the current system of the scan being assumed as part of the goniometer structure. I propose that we provide this using
scanspec
as it's an existing library which makes it easy to construct scans.Nexgen should probably still be responsible for creating the additional omega scan values (when none are provided) as this is a quirk of the nexus structure that omega values are always required so shouldn't be exposed to the user.
Acceptance Criteria
nexgen
can be called with a full scan specification and will write thisnexgen
will create the omega scan part if this hasn't already been providedNote