DiamondLightSource / pmac

Driver for the Delta Tau PMAC motion controller family.
Apache License 2.0
25 stars 17 forks source link

Add velocity array support for trajectories scan #102

Closed LeandroMartinsdS closed 1 year ago

LeandroMartinsdS commented 1 year ago

This PR is related to the working in progress to remove the velocities calculation from the motion program, and bring it to the driver level.

Some points that still need to be addressed, some of them discussed with @coretl , @ajgdls and @JimboMonkey :

If I'm missing something, please let me know.

ajgdls commented 1 year ago

Hi @LeandroMartinsdS I agree with your bullet list of tasks to complete this implementation.

ajgdls commented 1 year ago

Hi @LeandroMartinsdS at the moment it is not possible to download the motion programs to the PMAC. I think there are a few syntax errors in the pmc files. I would recommend the following checks:

ajgdls commented 1 year ago

Hi @LeandroMartinsdS mostly minor comments, just the velocity mapping that looks incorrect (V and W mixed).

LeandroMartinsdS commented 1 year ago

@ajgdls changes are all pushed.