search

DiamondLightSource / pmac

Driver for the Delta Tau PMAC motion controller family.
Apache License 2.0
25 stars 17 forks source link

Arm ppmac driver fix #103

Closed ajgdls closed 1 year ago

ajgdls commented 1 year ago

Fix a problem with the PowerPMAC driver that is exposed by the Arm version of the motion controller. In this version it is possible for messages to arrive without the trailing characters (CR LF) after the command terminator (BELL). This would mean that the next command echo is prefixed with those characters and corresponding status updates could become out of sync. The driver has been improved to ensure that these extra characters are checked for and the driver blocks until they are received (or a timeout occurs). In reality they always arrive within a ms or so. Some additional debugging log messages have been added.

There are some additional updates planned to improve this driver further, but this is a functional fix for the problem described above.

ajgdls commented 1 year ago

Hi @JimboMonkey those changes have been pushed.