search

DiamondLightSource / pmac

Driver for the Delta Tau PMAC motion controller family.
Apache License 2.0
25 stars 17 forks source link

Fix motor off updating cs #123

Closed LeandroMartinsdS closed 4 months ago

LeandroMartinsdS commented 6 months ago

This pull request patches the feature of updating the CS axis VAL when the OFF of any motor belonging to the CS changes.

The feature was introduced in R2-6-1, and after removed in R2-6-2 due to a Segmentation Fault occurring when a motor is allocated to a CS not declared in the builder.

JamesOHeaDLS commented 6 months ago

Looks good to me - thanks

guirodrigueslima commented 6 months ago

Hi @LeandroMartinsdS and @JamesOHeaDLS

I didn't notice this problem during the development of version R2-6-1, how was it discovered?

Do you have an estimated date for the new merge?

Thanks!

LeandroMartinsdS commented 4 months ago

Hi @guirodrigueslima,

Sorry for the long silence.

That issue was observed when we have added a new motor into a a controller, where this motor was addressed to a coordinate system in the controller's project with no need, and therefore wasn't declared in the IOC builder. The segmentation fault didn't happen using pmac driver previous releases .

I will merge this feature and tag it as 2-6-4b1.