DiamondLightSource / python-copier-template

Replacing Diamond Light Source's python3-pip-skeleton using Copier
Apache License 2.0
4 stars 2 forks source link

Replace references to "skeleton" #137

Closed joeshannon closed 3 months ago

joeshannon commented 4 months ago

A very minor issue but I noticed a couple of references to "skeleton" which could probably be replaced:

README.md:<img src="https://raw.githubusercontent.com/DiamondLightSource/python3-pip-skeleton-cli/main/docs/images/dls-logo.svg"
docs/conf.py:# 2. Existing project with latest skeleton, switcher exists and works
docs/conf.py:# 3. Existing project with old skeleton that makes broken switcher,
docs/conf.py:# Point 3 makes checking switcher difficult, because the updated skeleton
docs/conf.py:            "url": "https://pypi.org/project/python3-pip-skeleton",
template/{% if sphinx %}docs{% endif %}/conf.py.jinja:# 2. Existing project with latest skeleton, switcher exists and works
template/{% if sphinx %}docs{% endif %}/conf.py.jinja:# 3. Existing project with old skeleton that makes broken switcher,
template/{% if sphinx %}docs{% endif %}/conf.py.jinja:# Point 3 makes checking switcher difficult, because the updated skeleton

Most impactful one is probably the url in the conf.py as this makes it into the button in the docs.

joeshannon commented 4 months ago

There is also docs/images/git_merge.png which is skeleton related, should that be removed too?

coretl commented 4 months ago

Yes, that file can also go

joeshannon commented 3 months ago

I saw you merged the PR - did you delete docs/images/git_merge.png in a different change?

coretl commented 3 months ago

I did not...