DiamondLightSource / python-copier-template

Diamond's opinionated copier template for pure Python projects managed by pip
Apache License 2.0
5 stars 3 forks source link

add dependencies checker to the release workflow #199

Closed stan-dot closed 1 week ago

stan-dot commented 1 month ago

Fixes #182

stan-dot commented 1 month ago

no idea why is this failing, the change in this PR was to the release workflow logic, which was not even ran here

FAILED tests/test_example.py::test_example_repo_updates - AssertionError: You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.

assert 1 == 0
 +  where 1 = CompletedProcess(args=['copier', 'update', '--trust', '--vcs-ref=HEAD', '--data-file', '/home/runner/work/python-copier-template/python-copier-template/example-answers.yml'], returncode=1, stdout=b'You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.\n').returncode
coretl commented 1 month ago

no idea why is this failing, the change in this PR was to the release workflow logic, which was not even ran here

FAILED tests/test_example.py::test_example_repo_updates - AssertionError: You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.

assert 1 == 0
 +  where 1 = CompletedProcess(args=['copier', 'update', '--trust', '--vcs-ref=HEAD', '--data-file', '/home/runner/work/python-copier-template/python-copier-template/example-answers.yml'], returncode=1, stdout=b'You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.\n').returncode

Part of the CI updates the example repo, so you need to rebase any PRs on main. This is 39 commits behind main at the moment, which means it tries to downgrade the example repo as part of the checks

coretl commented 1 month ago

Please also provide:

stan-dot commented 1 month ago

I just added 'fixes issue'

https://github.com/DiamondLightSource/python-copier-template/issues/182

stan-dot commented 1 month ago

maybe I forgot about the part where it's tested in a separate project

coretl commented 1 month ago

Please add this to another project first and report back the useful information that it produced so we can review if it's worth adding

stan-dot commented 1 month ago

ok

stan-dot commented 1 month ago

https://github.com/DiamondLightSource/dodal/issues/825

stan-dot commented 1 week ago

this particular PR is no longer needed, as the chosen then package isn't well maintained and proved problematic in dodal

potential alternative packages: https://github.com/DiamondLightSource/dodal/pull/861#issuecomment-2454242068