Closed coretl closed 7 months ago
The pypi job needs a secret, but this needs to be explicitly passed in reusable workflows. The following needs editing: https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/template/%7B%25%20if%20git_platform%3D%3D%22github.com%22%20%25%7D.github%7B%25%20endif%20%25%7D/workflows/ci.yml.jinja#L52-L57 https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/_pypi.yml#L1-L2
An example of this secret passing is in the example deploy: https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/ci.yml#L36-L37 https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/_example.yml#L3-L5
We will throw this secret passing away after #40, but we need a release before with this fix so there is an intermediate working version
The pypi job needs a secret, but this needs to be explicitly passed in reusable workflows. The following needs editing: https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/template/%7B%25%20if%20git_platform%3D%3D%22github.com%22%20%25%7D.github%7B%25%20endif%20%25%7D/workflows/ci.yml.jinja#L52-L57 https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/_pypi.yml#L1-L2
An example of this secret passing is in the example deploy: https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/ci.yml#L36-L37 https://github.com/DiamondLightSource/python-copier-template/blob/ce6d7bbcea48f2be00ec30135c5dc756d1f56aaf/.github/workflows/_example.yml#L3-L5
We will throw this secret passing away after #40, but we need a release before with this fix so there is an intermediate working version