search

DiamondLightSource / python3-pip-skeleton

Archived in favour of https://github.com/DiamondLightSource/python-copier-template
Apache License 2.0
4 stars 4 forks source link

Lack of dockerignore file #137

Open AlexanderWells-diamond opened 1 year ago

AlexanderWells-diamond commented 1 year ago

Currently there is no .dockerignore file. This presents a problem if a user installs their venv into the folder and later tries to use the Dev Container. It results in the container build trying to copy in the entirety of that virtual environment. In my case that copy was running for 10 minutes before I gave up and cancelled it.

A .dockerignore file should be added to cover venv, .venv, and similar folders.

gilesknap commented 1 year ago

I vote for .venv venv as I find it useful to put contextual suffixes on venv folders.

gilesknap commented 1 year ago

Um, or it should match .gitignore which is the same as the above