DiamondLightSource / python3-pip-skeleton

Archived in favour of https://github.com/DiamondLightSource/python-copier-template
Apache License 2.0
5 stars 5 forks source link

Move config to pyproject.toml #80

Closed garryod closed 1 year ago

garryod commented 1 year ago

I've went ahead and moved all configuration from the setup.cfg to the pyproject.toml. Unfortunately tox doesn't support this very well, but it works

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (cc24758) into main (fa99c26) will not change coverage. The diff coverage is n/a.

:exclamation: Current head cc24758 differs from pull request most recent head b85e5cb. Consider uploading reports for the commit b85e5cb to get more accurate results

@@            Coverage Diff            @@
##              main       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           16        16           
=========================================
  Hits            16        16           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gilesknap commented 1 year ago

Looks great.

Not sure why the tests are still failing for python 3.8/9 ?

garryod commented 1 year ago

Looks great.

Not sure why the tests are still failing for python 3.8/9 ?

I used importlib.metadata to check the README, but the description key was only added in 3.10. See: https://github.com/DiamondLightSource/python3-pip-skeleton/pull/80/commits/e90d9101d13faeebababf3e8bf7cdab2fee98033

coretl commented 1 year ago

I thought flake8 didn't support pyproject.toml?

coretl commented 1 year ago

Ahh, I see Flake8-pyproject

coretl commented 1 year ago

Also, what's the use case for https://pypi.org/project/flake8-pyi/? I'm a little concerned by:

Note: Be careful when using this plugin in the same environment as other flake8 plugins, as they might generate errors that are inappropriate for .pyi files (e.g., about missing docstrings). We recommend running flake8-pyi in a dedicated environment in your CI.

garryod commented 1 year ago

Also, what's the use case for https://pypi.org/project/flake8-pyi/? I'm a little concerned by:

Note: Be careful when using this plugin in the same environment as other flake8 plugins, as they might generate errors that are inappropriate for .pyi files (e.g., about missing docstrings). We recommend running flake8-pyi in a dedicated environment in your CI.

This PR is not supposed to alter the functionality of skeleton, flake8-pyi must've been copied over from the reference project in error. I will open a separate issue regarding skeleton for extension modules using the C-API, for which flake8-pyi is a crucial piece of tooling

coretl commented 1 year ago

Please can you squash to a single commit and I'll merge

garryod commented 1 year ago

Please can you squash to a single commit and I'll merge

Done!