DiamondLightSource / pythonSoftIOC

Embed an EPICS IOC in a Python process
Apache License 2.0
34 stars 9 forks source link

Update to work with pvsxlibs 1.3.0 #146

Closed AlexanderWells-diamond closed 10 months ago

AlexanderWells-diamond commented 10 months ago

This version changed the name of its inbuilt .dbd files, which we must match in order to load it

Also updated various other dependencies in order to make the pipenv environment stable

Closes #145

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f2330b6) 87.73% compared to head (dd63ac8) 87.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ========================================== - Coverage 87.73% 87.43% -0.30% ========================================== Files 14 14 Lines 1019 1019 ========================================== - Hits 894 891 -3 - Misses 125 128 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Unit Test Results

     15 files  ±0       15 suites  ±0   28m 20s :stopwatch: -8s    278 tests ±0     262 :heavy_check_mark: ±0    16 :zzz: ±0  0 :x: ±0  4 170 runs  ±0  3 575 :heavy_check_mark: ±0  595 :zzz: ±0  0 :x: ±0 

Results for commit dd63ac83. ± Comparison against base commit f2330b64.

:recycle: This comment has been updated with latest results.

coretl commented 10 months ago

@mdavidsaver is this the correct fix?

mdavidsaver commented 10 months ago

This version changed the name of its inbuilt .dbd files

This was not intentional (mdavidsaver/pvxs#65). fyi. renaming/removal of a .dbd file is to my mind an incompatible API change, which would trigger a major version increment.

mdavidsaver commented 10 months ago

Fixed in pvxslibs==1.3.1. I have "yanked" 1.3.0 on pypi.org.

It would help in detecting issues like this if pythonSoftIOC could add a CI job testing the current 'master' branches of epicscorelibs, pvxs, and p4p.

AlexanderWells-diamond commented 10 months ago

PR is no longer necessary.