DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Include wiring for isolated components #120

Closed abbiemery closed 1 year ago

abbiemery commented 1 year ago

Fixes #96

codecov[bot] commented 1 year ago

Codecov Report

Merging #120 (0488d5d) into master (ada93e7) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   92.32%   92.34%   +0.01%     
==========================================
  Files          44       44              
  Lines        1186     1189       +3     
==========================================
+ Hits         1095     1098       +3     
  Misses         91       91              
Impacted Files Coverage Δ
src/tickit/core/management/event_router.py 97.80% <100.00%> (+0.07%) :arrow_up:
abbiemery commented 1 year ago

I have added the extra device graphs and parameterised some of the tests as requested.

@callumforrester please may you look at this for me? I haven't parameterised all of them because it felt a bit overkill but I can do if you think I should.

Also the test file is now over 600 lines long, should we move the graph fixtures into other files?