search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Ignore empty strings in SplittingInterpreter #133

Closed joeshannon closed 1 year ago

joeshannon commented 1 year ago

The splitting originally did behave like this but was modified. It is not clear what the use case for empty strings would be and this behaviour prevents further work to integrate PMAC.

codecov[bot] commented 1 year ago

Codecov Report

Merging #133 (41e9b49) into master (ad4499e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          45       45           
  Lines        1225     1225           
=======================================
  Hits         1133     1133           
  Misses         92       92
Impacted Files Coverage Δ
...ers/interpreters/wrappers/splitting_interpreter.py 100.00% <ø> (ø)
joeshannon commented 1 year ago

Fixes #114

garryod commented 1 year ago

Iirc, one of the devices @MattPrit was working on did blank strings between delimiters, though I cannot recall which one. Though I believe @DominicOram may have changed this device to use something regex based

DominicOram commented 1 year ago

I don't remember why we did this, it would have been for PMAC integration though. Regardless, I think this change is fine.