search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Use `type` as type of Inputs/Outputs fields #138

Closed tpoliaw closed 1 year ago

tpoliaw commented 1 year ago

The class variables are types rather than instances in their own right so should be typed as such. This allows type checkers to correctly check key lookups.

codecov[bot] commented 1 year ago

Codecov Report

Merging #138 (2d51839) into master (c8e0fbd) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 2d51839 differs from pull request most recent head 95a1e4c. Consider uploading reports for the commit 95a1e4c to get more accurate results

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          45       45           
  Lines        1225     1225           
=======================================
  Hits         1133     1133           
  Misses         92       92
Impacted Files Coverage Δ
src/tickit/devices/iobox.py 97.22% <100.00%> (ø)
src/tickit/devices/sink.py 94.11% <100.00%> (ø)
src/tickit/devices/source.py 95.45% <100.00%> (ø)
tpoliaw commented 1 year ago

tickit-devices change made here