DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Provide a System simulation adapter for zebra developments #139

Closed abbiemery closed 1 year ago

abbiemery commented 1 year ago

One solution for providing a degree of introspection of a zebradevice on its own components.

This generalises Adapters and provides a SystemSimulationView which an adapter may use as a "device". This view allows some interaction with the SystemSimulation component while obscuring access to the component logic. The SystemSimulationView provides references to the components and the wiring of the SystemSimulationComponent, and the SystemSimulationAdapter allows basic querying of these.

There is a ZebraAdapter for @DiamondJoseph as an idea of where the zebra work with the register etc can begin. I will remove this before merging.

codecov[bot] commented 1 year ago

Codecov Report

Merging #139 (0d00c0f) into master (17255c6) will decrease coverage by 0.76%. The diff coverage is 81.94%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   94.97%   94.22%   -0.76%     
==========================================
  Files          44       46       +2     
  Lines        1294     1350      +56     
==========================================
+ Hits         1229     1272      +43     
- Misses         65       78      +13     
Impacted Files Coverage Δ
src/tickit/views/system_simulation_view.py 68.75% <68.75%> (ø)
src/tickit/adapters/system_simulation_adapter.py 79.41% <79.41%> (ø)
src/tickit/core/components/system_simulation.py 96.07% <85.71%> (-1.70%) :arrow_down:
src/tickit/adapters/composed.py 60.00% <100.00%> (ø)
src/tickit/adapters/epicsadapter/adapter.py 100.00% <100.00%> (ø)
src/tickit/adapters/httpadapter.py 100.00% <100.00%> (ø)
src/tickit/core/adapter.py 92.85% <100.00%> (ø)
abbiemery commented 1 year ago

Closed in favour of #174