Closed rosesyrett closed 1 year ago
Merging #144 (70cad53) into master (6e22b8d) will increase coverage by
0.01%
. The diff coverage is100.00%
.:exclamation: Current head 70cad53 differs from pull request most recent head 815a14e. Consider uploading reports for the commit 815a14e to get more accurate results
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 92.48% 92.50% +0.01%
==========================================
Files 45 45
Lines 1225 1227 +2
==========================================
+ Hits 1133 1135 +2
Misses 92 92
Impacted Files | Coverage Δ | |
---|---|---|
src/tickit/core/components/component.py | 96.29% <100.00%> (ø) |
|
src/tickit/core/management/schedulers/base.py | 97.95% <100.00%> (ø) |
|
src/tickit/core/typedefs.py | 91.83% <100.00%> (+0.34%) |
:arrow_up: |
Is it not possible to have the aliases declared in the same way as the other typedefs?
As in using NewType
s? I think that would mean you had to wrap every use with ComponentOutput(...)
where they're used to avoid upsetting the type checker. TypeAliases mean the rest of the code doesn't have to change.
solves https://github.com/dls-controls/tickit/issues/117