search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
6 stars 0 forks source link

[DAQ-4742] remove runner module and replace with inline content #164

Closed mpdickie closed 1 year ago

mpdickie commented 1 year ago

The run_all method in runner.py was used in just two places and was very small, so we can replace the invocation of that method with using the content of that method inline.

tpoliaw commented 1 year ago
  • The system_simulation run_all also needs reworking.

beyond removing the import?

test_system_simulation and test_device_simulation. They both patch the run_all call from those components.

They both have a fixture to patch it but I can't see where either of them are used. The same with tickit_task - is it used anywhere?

abbiemery commented 1 year ago
  • The system_simulation run_all also needs reworking.

beyond removing the import?

No just removing the import and just having a comprehension, same as in the device_simulation.

test_system_simulation and test_device_simulation. They both patch the run_all call from those components.

They both have a fixture to patch it but I can't see where either of them are used. The same with tickit_task - is it used anywhere?

I just checked through and you are right, patch_run_all is not actually used in test_system_simulation or test_device_simulation. Also tickit_process and tickit_task are not used anywhere anymore. So can all can go.

abbiemery commented 1 year ago

Fixes #118