search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
6 stars 0 forks source link

Remove click pin #167

Closed rosesyrett closed 1 year ago

rosesyrett commented 1 year ago

The latest version of click addresses the typing issues of click.group() meaning we should be able to unpin it now.

rosesyrett commented 1 year ago

The best way I can see is explicitly going,

click!=8.1.0,!=8.1.1,!=8.1.2

etc until 8.1.4. It seems our issues are fixed only in 8.1.5. This seems messy to me but I'm happy to implement it.

tpoliaw commented 1 year ago

That sounds like an overkill, it's only the type checking that has problems, right?

garryod commented 1 year ago

Should be able to do click>=8.1.5,<8.1.0. See PEP508

abbiemery commented 1 year ago

I thought everything up to and including 8.1.3 worked, and just 8,1,4 and 8.1.5 didn't? So:

click>=8.1.5,<8.1.4 or click>=8.1.5,<=8.1.3 if you wan't to be extra clear

abbiemery commented 1 year ago

Turns out it really doesn't like refining excluded ranges with inequalities, and since it's only 2 versions which don't work lets just pin those.

codecov[bot] commented 1 year ago

Codecov Report

Merging #167 (96ea008) into master (fca2148) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          44       44           
  Lines        1310     1310           
=======================================
  Hits         1245     1245           
  Misses         65       65