DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
6 stars 0 forks source link

Unify naming of device and system components #187

Closed abbiemery closed 1 year ago

abbiemery commented 1 year ago

There was some overlap in naming between components and simulations which lead to some confusion. I have changed the naming to add clarity.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (eba276e) 94.68% compared to head (aee2c8c) 94.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #187 +/- ## ======================================= Coverage 94.68% 94.68% ======================================= Files 41 41 Lines 1318 1318 ======================================= Hits 1248 1248 Misses 70 70 ``` | [Files Changed](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls) | Coverage Δ | | |---|---|---| | [src/tickit/adapters/system.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9hZGFwdGVycy9zeXN0ZW0ucHk=) | `100.00% <ø> (ø)` | | | [src/tickit/core/components/component.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9jb3JlL2NvbXBvbmVudHMvY29tcG9uZW50LnB5) | `96.29% <ø> (ø)` | | | [src/tickit/devices/iobox.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9kZXZpY2VzL2lvYm94LnB5) | `97.43% <50.00%> (ø)` | | | [src/tickit/core/components/device\_component.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9jb3JlL2NvbXBvbmVudHMvZGV2aWNlX2NvbXBvbmVudC5weQ==) | `100.00% <100.00%> (ø)` | | | [src/tickit/core/components/system\_component.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9jb3JlL2NvbXBvbmVudHMvc3lzdGVtX2NvbXBvbmVudC5weQ==) | `94.11% <100.00%> (ø)` | | | [src/tickit/devices/sink.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9kZXZpY2VzL3NpbmsucHk=) | `100.00% <100.00%> (ø)` | | | [src/tickit/devices/source.py](https://app.codecov.io/gh/dls-controls/tickit/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dls-controls#diff-c3JjL3RpY2tpdC9kZXZpY2VzL3NvdXJjZS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.