DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Improve ZeroMQ Adapter Message Serilization Error Handling #196

Open callumforrester opened 1 year ago

callumforrester commented 1 year ago

The ZMQ adapter serializes messages before pushing, there are currently two major issues with this: It raises an exception when it gets an empty message (i.e. []) and said exception is swallowed, along with any other serialization errors.

GDYendell commented 1 year ago

Is it expected that adding an empty message to the queue would do something useful? It could handle empty messages more explicitly to allow reporting of serialization errors of messages with actual content.