search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Add support for removing fixed-length headers from interpreted messages #80

Closed MattPrit closed 2 years ago

MattPrit commented 2 years ago

Fixes #78

DominicOram commented 2 years ago

I believe failing tests are due to https://github.com/tholo/pytest-flake8/issues/87 and unrelated to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #80 (da5451b) into master (eac7366) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          65       67    +2     
  Lines        2085     2097   +12     
=======================================
+ Hits         2055     2067   +12     
  Misses         30       30
Impacted Files Coverage Δ
tickit/adapters/interpreters/wrappers/__init__.py 100.00% <100.00%> (ø)
...ers/interpreters/wrappers/beheading_interpreter.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

DominicOram commented 2 years ago

Generally looks good to me (as we pair programmed some of it) but could you add some user docs to https://github.com/dls-controls/tickit/blob/master/docs/tutorials/creating-an-adapter.rst?

DominicOram commented 2 years ago

Do expedite merging I have pulled documentation into https://github.com/dls-controls/tickit/issues/87