Closed MattPrit closed 2 years ago
Merging #82 (2a0ad1e) into master (f4b3625) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 98.58% 98.59% +0.01%
==========================================
Files 69 70 +1
Lines 2117 2141 +24
==========================================
+ Hits 2087 2111 +24
Misses 30 30
Impacted Files | Coverage Δ | |
---|---|---|
...apters/interpreters/command/command_interpreter.py | 100.00% <100.00%> (ø) |
|
tickit/adapters/interpreters/utils.py | 100.00% <100.00%> (ø) |
|
tickit/adapters/interpreters/wrappers/__init__.py | 100.00% <100.00%> (ø) |
|
...ers/interpreters/wrappers/splitting_interpreter.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Currently, should any of the sub-messages/commands raise an interrupt, the interrupt is only raised after all the commands have been executed. This means that a list of commands sent in a single message will not necessarily result in the same behavior as if each command was sent in its own message, despite being executed in the same order. This could be fixed by #84.
Currently, should any of the sub-messages/commands raise an interrupt, the interrupt is only raised after all the commands have been executed. This means that a list of commands sent in a single message will not necessarily result in the same behavior as if each command was sent in its own message, despite being executed in the same order. This could be fixed by #84.
Would you like to block this merge until #84 is in place and we can replicate the "correct" behaviour, or merge early and track it with an issue?
As discussed, I think converting this to a generic regex
splitter, with splitting on
being the default, would be good. Could you also add docs as part of https://github.com/dls-controls/tickit/issues/87
Currently, should any of the sub-messages/commands raise an interrupt, the interrupt is only raised after all the commands have been executed. This means that a list of commands sent in a single message will not necessarily result in the same behavior as if each command was sent in its own message, despite being executed in the same order. This could be fixed by #84.
Would you like to block this merge until #84 is in place and we can replicate the "correct" behaviour, or merge early and track it with an issue?
I suggest merging now and creating a new issue for the next part.
Note that is is now only a partial fix for #77. A full fix requires a more complex interpreter.
Converted to draft because it requires #89 to be merged first.
Fixes #77