search

DiamondLightSource / tickit

Event-based hardware simulation framework
Apache License 2.0
7 stars 0 forks source link

Fix cursed CI issues #98

Closed abbiemery closed 2 years ago

abbiemery commented 2 years ago

For some reason --verbose on the pipenv install makes the dependencies resolve, whereas without it it doesn't ?

abbiemery commented 2 years ago

@callumforrester also the codecov just failed? for changes in code outside the coverage area?

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (29dd0b0) into master (b15df3c) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files          70       69       -1     
  Lines        2141     2139       -2     
==========================================
- Hits         2111     2109       -2     
  Misses         30       30
Impacted Files Coverage Δ
tickit/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

abbiemery commented 2 years ago

This blank line was added to the end of the tickit __init__ by flake8, which cause codecov to complain. I've taken it out but fully expect flake8 to now complain.

abbiemery commented 2 years ago

This blank line was added to the end of the tickit __init__ by flake8, which cause codecov to complain. I've taken it out but fully expect flake8 to now complain.

Yep. Now Flake8 and Black all fail.