search

DiamondNath07 / jsCapstone

This is a web application that renders data using the pokeApi and also features a counter API to keep track of the numbers of likes a particular cartoon has. It also takes record of visitors comments and displays it on a pop-up page
MIT License
0 stars 0 forks source link

JavaScript Kanban Board #21

Open DiamondNath07 opened 1 year ago

DiamondNath07 commented 1 year ago

![image](https://user-images.githubusercontent.com/99302635/206385349-8fa53b42-eb09-46e9-835d-e31bcec22c2a.png

Below is the project link and I will be working solo as approved by student success https://github.com/users/DiamondNath07/projects/1

Abenezer-Tilahun commented 1 year ago

Hi @DiamondNath07 ,

Great job so far, There are some changes that need to be implemented in order to proceed to the next project 👍

Highlights 👏🏻

✔️Successfully set up your Kanban board ✔️ Provide link to your GitHub project and how many people there are in your team.

almost

Required Changes ♻️

Capture

Check the comments below the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

danmainah commented 1 year ago

Hi @Abenezer-Tilahun ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉

Highlights

✔️Successfully set up your Kanban board ✔️ Provide link to your GitHub project and how many people there are in your team.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.