DiamondPrecisionComputing / unraid-templates

Central storage for unRAID Templates
GNU General Public License v3.0
3 stars 6 forks source link

Gluetun template: add `LOG_LEVEL` variable #3

Closed qdm12 closed 3 years ago

qdm12 commented 3 years ago

@DiamondPrecisionComputing let me know if I need to add something somewhere else for environment variables.

I have to add a bunch of them, so I'll use this one as a learning example.

DiamondPrecisionComputing commented 3 years ago

That looks good. I've been trying to keep up with the variables you mark as required and put them in the template. Doesn't always happen but I try.

My only comments I guess are these. I try to keep similar variables grouped together when I can. A cool feature I like to use when possible is in the Default field in the variably line I separate variable answers with |. This basically makes it a dropdown with only specific entries. That way I know no matter what the user chooses it will be accepted. And if it's a niche variable then I mark it as advanced so it only shows up for users that have the advanced switch on when filling out the template in the appstore.

qdm12 commented 3 years ago

Thanks! Also another question, don't I have to add the variable to the table (in that ugly html like code) like

          <p>
             <em>
             VPN_USER
             </em>
          </p>
DiamondPrecisionComputing commented 3 years ago

No, that is only for the description that shows up in the appstore. It's not necessary to show up in the appstore template.

It is incredibly ugly but it's what works lol. If you ever want that description to change let me know and I'll get that added.

Sent from ProtonMail mobile

-------- Original Message -------- On Sep 10, 2021, 6:06 PM, Quentin McGaw wrote:

Thanks! Also another question, don't I have to add the variable to the table (in that ugly html like code) like

<p> <em> VPN_USER </em> </p>

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.