search

DianaIonita / serverless-api-gateway-caching

A plugin for the Serverless framework which helps with configuring caching for API Gateway endpoints.
ISC License
136 stars 35 forks source link

AWS proxy passes all header pathparameters, and body on by default ad… #50

Closed jonathanalberghini closed 5 years ago

jonathanalberghini commented 5 years ago

…ding to integration request makes header unavailible to authorizor functions.

Hi Jonathan,

Mariam here from AWS Premium Support with a follow up to our call earlier.

During our chat, I confirmed with you that an API Gateway with a proxy integration (AWS Proxy or HTTP proxy) does not give you the option to set request parameters for the method's Integration Request as the full HTTP request is passed through to the backend.

You pointed me in the direction of this document [1] which states that in the value set for "CacheKeyParameters" must be set as a request parameter.

However in the meantime, I will be in touch with the internal API Gateway experts with regards to the documentation and get back to you tomorrow with our findings and some official wording.

Please do let me know if you have any additional questions. In the meantime, I will give you a call tomorrow at about 12pm UTC. Could you please confirm tha the best number to reach you on and I will be in touch.

Have a great day and chat soon.

[1] https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-integration-settings-integration-request.html

Best regards,

Mariam N. Amazon Web Services

DianaIonita commented 5 years ago

Hey @jonathanalberghini, thanks for the PR, but I've just merged in another almost identical one. You might want to edit out your phone number from the PR description.

jonathanalberghini commented 5 years ago

Yeah i never got a response from you so i asked the guys at serverless to put one in to.

Thanks.