search

DianaIonita / serverless-api-gateway-throttling

A plugin for the Serverless framework which configures throttling for API Gateway endpoints.
ISC License
69 stars 7 forks source link

Disable throttling settings by default #11

Closed scadu closed 3 years ago

scadu commented 3 years ago

An attempt to fix #5

scadu commented 3 years ago

TODO: Add tests. Looking into current test scenarios.

DianaIonita commented 3 years ago

Hi @scadu,

Thanks for finding this solution. Indeed, if you set -1 as the values for a method's throttling settings, it makes it so that it inherits the throttling values from the stage.

However, the place for this logic may be where the settings object is generated here. It's also easier to add tests around it.

Thanks for raising the PR!

scadu commented 3 years ago

@DianaIonita thanks for the feedback! I'll update the PR soon.