use classes

[rimmesbe]

I'd prefer a class used for this styling, this way we don't lock the span down with specific styling incase we want to use it later in a different manner. Also you can use a descriptive class name to make the html more understandable.

https://github.com/DianaKado/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/resources/css/styles.css#L25-L28

[DianaKado]

So, combining this with your suggestion to use strong tags instead of span tags, would the following code be more suitable? (first and last html brackets <> are missing because of styling markdowns in github)

strong class="price">Starting at $3.00 / brush.</strong strong class="price">Starting at $2.00 / frame.</strong strong class="price">Starting at $5.00 / tube.</strong

in the html file and

.price { font-weight: bold; color: blue; }

in the css file. If I upload the updated files, should I upload it to the master or a branch?

Thanks.

[rimmesbe]

Yes that is better, except you won't need font-weight: bold; in the css since strong tag makes it bold.

On Tue, Jun 27, 2017 at 12:52 AM, Diana Kado notifications@github.com wrote:

So, combining this with your suggestion to use tags instead of , would the following code be more suitable?

• Starting at $3.00 / brush. Starting at $2.00 / frame. Starting at $5.00 / tube. in the html file and .price { font-weight: bold; color: blue; } in the css file.*

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DianaKado/prj-rev-bwfs-dasmoto/issues/4#issuecomment-311252542, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfw_G_5gIoiOGCKrOLUIaMSeUJnJA4Qks5sIIqKgaJpZM4OF9Y8 .

[DianaKado]

Oh, yes, the thought came up early this morning. Font-weight: bold; in css is redundant with strong as it is with the headings. Good to point out. I made the change. Thanks.