search

DianaOlympos / Andromeda

A little fleet helper
Other
3 stars 1 forks source link

Any thoughts on separating SSO into a hex package? #3

Open st23am opened 8 years ago

st23am commented 8 years ago

Is there any interest in separating out Crest SSO into a separate hex package? Perhaps something like a uberauth strategy? https://github.com/ueberauth/ueberauth/wiki/List-of-Strategies.

If this something you would be interested in can try and work up a pull request to contribute back.

Thanks for opening this project up it is super interesting!

DianaOlympos commented 8 years ago

So couple things here

1) i am going to revisit, refactor and update Andromeda backend in the coming weeks, especially to add the fleet endpoint. What is here is more of a PoC.

2) Why not make a Hex package. Would need some thinking and maybe deal with different options but possible. Uberauth is another one. I find it a bit too big for what it bring but why not. Would need to check how to integrate it properly

3) There was an idea of doing a full CREST library, with correct rate limiting with another dev, but we never really pushed the idea too far. Maybe having SSO in that would be a better idea ? I don't know.

Thank you for looking at it, i wonder how you found it. I will try to update it more but i need to find someone to deal with the frontend.

st23am commented 8 years ago

UeberAuth is pretty large I can understand wanting to keep your dependencies small. A CREST library would be awesome! As for how I found this I entered a google search for EVE CREST API and Elixir :)

I look forward to seeing where you take the code. Keep up the awesome work and fly safe o7